Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libp2p-webrtc: compiling fails with latest version 0.53.2 with feature flag noise #5117

Closed
Larkooo opened this issue Jan 22, 2024 · 1 comment · Fixed by #5118
Closed

libp2p-webrtc: compiling fails with latest version 0.53.2 with feature flag noise #5117

Larkooo opened this issue Jan 22, 2024 · 1 comment · Fixed by #5118

Comments

@Larkooo
Copy link

Larkooo commented Jan 22, 2024

Summary

libp2p-webrtc doesn't seem to compile due to the noise feature flag on the latest version of libp2p

Expected behavior

To compile

Actual behavior

Does not compile

Relevant log output

error[E0277]: `?` couldn't convert the error to `tokio::error::Error`
  --> /Users/nasr/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libp2p-webrtc-0.7.0-alpha/src/tokio/upgrade.rs:71:11
   |
71 |     .await?;
   |           ^ the trait `From<libp2p_noise::Error>` is not implemented for `tokio::error::Error`
   |
   = note: the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait
   = help: the following other types implement trait `From<T>`:
             <tokio::error::Error as From<libp2p_noise::Error>>
             <tokio::error::Error as From<webrtc::Error>>
             <tokio::error::Error as From<std::io::Error>>
   = note: required for `Result<(PeerId, Connection), tokio::error::Error>` to implement `FromResidual<Result<Infallible, libp2p_noise::Error>>`

error[E0277]: `?` couldn't convert the error to `tokio::error::Error`
   --> /Users/nasr/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libp2p-webrtc-0.7.0-alpha/src/tokio/upgrade.rs:105:11
    |
105 |     .await?;
    |           ^ the trait `From<libp2p_noise::Error>` is not implemented for `tokio::error::Error`
    |
    = note: the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait
    = help: the following other types implement trait `From<T>`:
              <tokio::error::Error as From<libp2p_noise::Error>>
              <tokio::error::Error as From<webrtc::Error>>
              <tokio::error::Error as From<std::io::Error>>
    = note: required for `Result<(PeerId, Connection), tokio::error::Error>` to implement `FromResidual<Result<Infallible, libp2p_noise::Error>>`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `libp2p-webrtc` (lib) due to 2 previous errors

Possible Solution

Releasing a new version? It seems like specifying git as the target source for the libp2p crate seems to fix it so maybe a fix has been released but version hasnt been updated.

Version

0.53.2

Would you like to work on fixing this bug ?

No

@thomaseizinger
Copy link
Contributor

This is now released, let me know if it works for you.

guillaumemichel pushed a commit that referenced this issue Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants