Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflow: Use ubuntu-18.04 fixing missing protoc binary #2368

Merged
merged 8 commits into from
Dec 6, 2021

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Dec 3, 2021

Debug CI failure on missing protoc binary.

Caused by:
process didn't exit successfully:
/home/runner/work/rust-libp2p/rust-libp2p/target/debug/build/libp2p-core-31f9552cf2db9053/build-script-build
(exit status: 101)
--- stderr
thread 'main' panicked at 'called Result::unwrap() on an Err
value: Custom { kind: NotFound, error: "failed to invoke protoc (hint:
https://docs.rs/prost-build/#sourcing-protoc): No such file or directory
(os error 2)" }', core/build.rs:30:6

Debug CI failure on missing protoc binary.

Caused by:
  process didn't exit successfully:
`/home/runner/work/rust-libp2p/rust-libp2p/target/debug/build/libp2p-core-31f9552cf2db9053/build-script-build`
(exit status: 101)
  --- stderr
  thread 'main' panicked at 'called `Result::unwrap()` on an `Err`
value: Custom { kind: NotFound, error: "failed to invoke protoc (hint:
https://docs.rs/prost-build/#sourcing-protoc): No such file or directory
(os error 2)" }', core/build.rs:30:6
@mxinden
Copy link
Member Author

mxinden commented Dec 6, 2021

Still not quite sure why this is failing. Might be the Virtual Environment Version change (Version: 20211122.1 -> Version: 20211129.1).

Interpreter /lib64/ld-linux-x86-64.so.2 is present.

https://github.com/tokio-rs/prost/blob/d6faf5a0690826bbe07fe2c7e29bbe29d1eb0534/prost-build/build.rs#L38-L54

@mxinden mxinden changed the title .github/workflow: Debug missing protoc .github/workflow: Use ubuntu-18.04 fixing missing protoc binary Dec 6, 2021
@mxinden
Copy link
Member Author

mxinden commented Dec 6, 2021

I will merge here, since this issue is blocking all other pull requests. I am happy to revisit this fix, especially in case anyone has alternative suggestions. Also I will create a reminder to check back in some months whether the bundled protoc binaries have been updated in prost-build.

@mxinden mxinden marked this pull request as ready for review December 6, 2021 14:53
@mxinden mxinden merged commit e021933 into libp2p:master Dec 6, 2021
canewsin added a commit to decentnetwork/rust-libp2p that referenced this pull request Dec 7, 2021
* protocols/relay: Implement circuit relay v2 protocol

This commit adds an implementation for the circuit relay v2 protocol to
be used as a relay server, i.e. it supports incoming HOP requests and
outgoing STOP requests. Future commits will add support for clients,
i.e. outgoing HOP requests and incoming STOP requests.

The existing circuit relay v1 protocol implementation is moved to
protocols/relay/src/v1.

* misc/multistream-select: Ignore simultaneous open 'iamclient'

* protocols/relay: Ensure connections of HOP connect are kept alive

* protocols/relay: Improve documentation

* protocols/relay: Implement v2 client logic

* protocols/relay: Handle dial failure

* protocols/relay: Reuse connection

* protocols/relay: Rename Connection to RelayedConnection

* protocols/relay: Update transport doc examples

* protocols/relay: Pass relay addr to transport

* protocols/relay: Implement inbound stop denial

* protocols/relay: Renew reservations

* protocols/relay: Handle invalid expiration in the past

* protocols/relay: Handle in and outbound failure

* protocols/relay: Implement client handler keep alive

* protocols/relay: Handle handler listener closed channel

* protocols/relay: Handle handler to listener failure

* protocols/relay: Return all new listener addresses

* protocols/relay/v2: Update to latest protobuf definition

* Revert "misc/multistream-select: Ignore simultaneous open 'iamclient'"

This reverts commit 125e3c3.

* protocols/relay/v2: Report back to transport

* protocols/relay/v2: Disconnect when stop protocol not supported

* protocols/relay/v2: Document max_duration not exceed u32::MAX

* protocols/relay/v2: Don't append p2p-circuit as relay

* protocols/relay/v2: Implement rate limiter

* protocols/relay/v2: Document caveats on rate limiter with high volume

* protocols/relay: Prevent possible false positive in quickcheck

* protocols/relay: Reword Prost error message

* protocols/relay: Allow users to specify generic rate limiters

* protocols/relay: Move rate limiting logic into module

* protocols/relay: Prevent reservation and connection over relayed conn

* protocols/relay: Add circuit src rate limiting

* protocols/relay/v2: Simplify example

* protocols/relay: Add myself to authors

* protocols/relay: Use thiserror

* protocols/relay/v2: Set rate limits

* protocols/relay: Use wasm_timer::Instant

* protocols/relay/v2: Apply clippy suggestions

* protocols/relay: Fix intra doc link

* protocols/relay: Fix clippy warnings

* misc/metrics: Add basic instrumentation for libp2p-relay

* protocols/relay: Return NetworkBehaviourAction::NotifyHandler right away

* protocols/relay: Run rust fmt

* protocols/relay/src/v2/relay: Accept mutable config

* protocols/relay/examples: Structure command line args

- Allow deterministic peer identity.
- Choose between ipv6 and ipv4.

* .github/workflow: Use ubuntu-18.04 fixing missing protoc binary  (libp2p#2368)

`prost-build` is failing due to a missing `protoc` binary. Neither the OS
supplies one, nor can the bundled binaries be used. This commit downgrades the
OS used. The older OS is compatible with the bundled `protoc` binaries.

* *: Fix clippy errors from upgrade to Rust 1.57 (libp2p#2365)

* core: Mark "unused" field with "_"

We need to keep this marker type to ensure that the type continues
to be required to be pinned.

* tranports/noise: Derive `Default` for `Config`

`false` is the default for `bool`, we can derive this.

* protocols/request-response: Remove unused fields

These are already included the `RequestResponseMessage::Request`
variant.

* *: Allow clippy's large-enum-variant lint

Tackling these suggestions would require performance measurement
which we don't want to do at this stage.

Co-authored-by: Max Inden <mail@max-inden.de>

* protocols/mdns/: Generate peer expiry and fix IPv6 support (libp2p#2359)

Co-authored-by: Victor Ermolaev <victorermolaev@gmail.com>
Co-authored-by: Max Inden <mail@max-inden.de>

* protocols/floodsub: Propagate messages only to target peers (libp2p#2360)

Propagate messages only to the target peers and not all connected peers.

Co-authored-by: Victor Ermolaev <victorermolaev@gmail.com>
Co-authored-by: Max Inden <mail@max-inden.de>

* examples/*: Migrate to async await (libp2p#2356)

* Adapt examples to async style loop
* Adapt async style loop for chat.rs
* Adapt async style loop for distributed-key-value-store.rs
* Adapt async style loop for gossibsub-chat.rs
* Adapt async style loop for ipfs-private.rs
* Adapt ping to use async
* Update tutorial crate to reflect new changes

Co-authored-by: Max Inden <mail@max-inden.de>

* protocols/relay/src/v2/client: Return NetworkBehaviourAction on ListenReq

* Refactor suggestion

* protocols/relay/src/v2/client/handler: Check status of lend out substreams

* protocols/relay/src/v2/client: Use void::Void for drop_notifer

* protocols/relay/src/v2/client/handler: Log dropped oneshot Sender to transport

* protocols/relay/src/v2/client/handler: Await send call to transport listener

* protocols/relay/src/v2/client/handler: Remove unnecessary boxing

Co-authored-by: Max Inden <mail@max-inden.de>
Co-authored-by: ronzigelman <ronzigelman@gmail.com>
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Co-authored-by: Victor Ermolaev <16148931+vnermolaev@users.noreply.github.com>
Co-authored-by: Victor Ermolaev <victorermolaev@gmail.com>
Co-authored-by: Gerardo Enrique Arriaga Rendon <53304516+JerryHue@users.noreply.github.com>
Co-authored-by: Marco Munizaga <git@marcopolo.io>
mxinden added a commit that referenced this pull request Mar 11, 2022
mxinden added a commit that referenced this pull request Mar 17, 2022
…ry " (#2554)

* Revert ".github/workflow: Use ubuntu-18.04 fixing missing protoc binary  (#2368)"

* .github: Use llvm installation script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant