Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Rework reporting of invalid and wrong PeerIds #2441

Merged
merged 7 commits into from
Jan 18, 2022
Merged

*: Rework reporting of invalid and wrong PeerIds #2441

merged 7 commits into from
Jan 18, 2022

Commits on Jan 15, 2022

  1. fix peer_id in case of DialError::InvalidPeerId (libp2p#2425) 

    Previously, the negotiated PeerId was included in the swarm event and
inject_dial_failure’s arguments while the expected one was absent. This
patch adds the negotiated PeerId to the DialError and includes the expected
one in the notifications.
    @rkuhn
    rkuhn committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    1a8e772 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Max Inden <mail@max-inden.de>
    @rkuhn @mxinden
    rkuhn and mxinden committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    4bf8267 View commit details
    Browse the repository at this point in the history

  3. include remote address in InvalidPeerId error 

    also add changelog entries
    @rkuhn
    rkuhn committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    561b922 View commit details
    Browse the repository at this point in the history

  4. fix changelog entries (InvalidPeerId -> WrongPeerId)

    @rkuhn
    rkuhn committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    020f9b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. *: Carry ConnectedPoint in WrongPeerId error

    @mxinden
    mxinden committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    c1b0483 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'libp2p/master' into rku/invalid-peer-id

    @mxinden
    mxinden committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    c7f880e View commit details
    Browse the repository at this point in the history

  3. core/tests/network_dial_error: Match on ConnectedPoint

    @mxinden
    mxinden committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    17a1980 View commit details
    Browse the repository at this point in the history