Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm/behaviour: make either mod private #2610

Merged
merged 2 commits into from
Apr 7, 2022
Merged

swarm/behaviour: make either mod private #2610

merged 2 commits into from
Apr 7, 2022

Conversation

elenaf9
Copy link
Contributor

@elenaf9 elenaf9 commented Apr 7, 2022

Change the swarm::behaviour::either module to be private, since it has no public items: https://docs.rs/libp2p/latest/libp2p/swarm/behaviour/either/index.html.

mxinden
mxinden approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elenaf9!

@thomaseizinger thomaseizinger merged commit 102509a into libp2p:master Apr 7, 2022
@elenaf9 elenaf9 deleted the swarm/make-either-private branch April 8, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elenaf9 @thomaseizinger @mxinden