-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swarm/: Support generic connection management through NetworkBehaviour #2828
Closed
Commits on Aug 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3927ca2 - Browse repository at this point
Copy the full SHA 3927ca2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bfdba6 - Browse repository at this point
Copy the full SHA 7bfdba6View commit details
Commits on Aug 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 835394c - Browse repository at this point
Copy the full SHA 835394cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 553f280 - Browse repository at this point
Copy the full SHA 553f280View commit details
Commits on Aug 16, 2022
-
swarm-derive/: Add where clause of behaviour to generated out event
When generating the `OutEvent` for a `NetworkBehaviour`, add the `where` clause of the `NetworkBehaviour` `struct` to the generated `enum`.
Configuration menu - View commit details
-
Copy full SHA for cb42dd3 - Browse repository at this point
Copy the full SHA cb42dd3View commit details -
swarm-derive/: Derive Debug for generated OutEvent
When generating an `OutEvent` `enum` definition for a user, derive `Debug` for that `enum`. Why not derive `Clone`, `PartialEq` and `Eq` for the generated `enum` definition? While I think it is fine to require all sub-`OutEvent`s to implement `Debug`, I don't think the same applies to traits like `Clone`. I suggest users that need `Clone` to define their own `OutEvent`.
Configuration menu - View commit details
-
Copy full SHA for b4f1472 - Browse repository at this point
Copy the full SHA b4f1472View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f58ccd - Browse repository at this point
Copy the full SHA 3f58ccdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e682ec - Browse repository at this point
Copy the full SHA 0e682ecView commit details
Commits on Aug 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ebe1131 - Browse repository at this point
Copy the full SHA ebe1131View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7335a94 - Browse repository at this point
Copy the full SHA 7335a94View commit details -
Merge branch 'master' of https://github.com/libp2p/rust-libp2p into g…
…eneric-connection-management
Configuration menu - View commit details
-
Copy full SHA for 486daba - Browse repository at this point
Copy the full SHA 486dabaView commit details
Commits on Aug 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a7eb4cb - Browse repository at this point
Copy the full SHA a7eb4cbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.