Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multistream-select: Remove parallel dialing optimization #2934

Merged
merged 8 commits into from
Sep 29, 2022
Merged

multistream-select: Remove parallel dialing optimization #2934

merged 8 commits into from
Sep 29, 2022

Conversation

dignifiedquire
Copy link
Member

This is to avoid the usage of the now optional ls command, and stay compatible with go-multistream.

Closes #2925

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@dignifiedquire
fix(multistream-select): remove parallel dialing optimization
d326bee 
This is to avoid the usage of the now optional `ls` command, and stay compatible with go-multistream.

Closes libp2p#2925
@dignifiedquire dignifiedquire mentioned this pull request Sep 23, 2022
Closed
thomaseizinger
thomaseizinger approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I am okay with this change :)

misc/multistream-select/CHANGELOG.md Outdated Show resolved Hide resolved
misc/multistream-select/src/dialer_select.rs Outdated Show resolved Hide resolved
misc/multistream-select/src/tests.rs Outdated Show resolved Hide resolved
misc/multistream-select/src/tests.rs Outdated Show resolved Hide resolved
@thomaseizinger
Copy link
Contributor

thomaseizinger commented Sep 23, 2022 •
edited
Loading

I think we should also straight-up bump the version in the manifest file and use this new implementation in libp2p-core.

@dignifiedquire
Copy link
Member Author

I think we should also straight-up bump the version in the manifest file and use this new implementation in libp2p-core.

done

@mxinden mxinden mentioned this pull request Sep 23, 2022
Merged
4 tasks
@thomaseizinger thomaseizinger changed the title fix(multistream-select): remove parallel dialing optimization multistream-select: Remove parallel dialing optimization Sep 23, 2022
thomaseizinger
thomaseizinger approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

misc/multistream-select/tests/dialer_select.rs Outdated Show resolved Hide resolved
@dignifiedquire
Copy link
Member Author

@mxinden anyhing blocking from merging this PR? would be great to have this in

mxinden
mxinden approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dignifiedquire for debugging, reporting and fixing this!

misc/multistream-select/CHANGELOG.md Outdated Show resolved Hide resolved
@mxinden
Copy link
Member

mxinden commented Sep 28, 2022

Not sure why the interoperability tests are failing. I assume due to:

Sep 28 11:02:14.311833	INFO	1.1452s       FAIL << go-latest-v0.22[000] (2e992c) >> failed to dial 12D3KooWBK4ZGwm1kKpPucpiD57hGjvzuDvU4D6eyoLj5EQnNdcm:
  * [/ip4/16.0.0.4/tcp/1234] failed to negotiate security protocol: protocol not supported

I will look further into this.

@mxinden mxinden merged commit c71115d into libp2p:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove usage of the ls command in multistream-select
3 participants
@dignifiedquire @thomaseizinger @mxinden