Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mdns): remove deprecated items #3699

Merged
merged 8 commits into from
May 2, 2023

Conversation

umgefahren
Copy link
Contributor

@umgefahren umgefahren commented Mar 29, 2023

Description

Related: #3647.

Notes & open questions

Should be merged along with next breaking change to libp2p_mdns.

Change checklist

  • I have performed a self-review of my own code
  • A changelog entry has been made in the appropriate crates

@umgefahren umgefahren changed the title Remove deprecated Mdns prefixed items chore(mdns): Remove deprecated Mdns prefixed items Mar 29, 2023
@thomaseizinger thomaseizinger changed the title chore(mdns): Remove deprecated Mdns prefixed items chore(mdns): remove deprecated items Mar 29, 2023
@thomaseizinger thomaseizinger added this to the v0.52.0 milestone Mar 29, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

This pull request has merge conflicts. Could you please resolve them @umgefahren? 🙏

@mergify
Copy link
Contributor

mergify bot commented May 2, 2023

This pull request has merge conflicts. Could you please resolve them @umgefahren? 🙏

@thomaseizinger
Copy link
Contributor

We've now opened the merge window for breaking changes so this is good to go in once the merge conflicts are resolved.

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 30d2c75 into libp2p:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants