fix(relay): flush relayed connection once idle #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a relay, when forwarding data between relay-connection-source and -destination and vice versa, flush write side when read currently has no more data available.
mxinden
commented
Apr 11, 2023
| use quickcheck::QuickCheck; | ||
| use std::io::ErrorKind; | ||
| use std::pin::Pin; | ||
| use std::task::{Context, Poll}; | ||
| use std::time::Duration; | ||
|
|
||
| struct Connection { |
There was a problem hiding this comment.
To make confusing diff easier to read:
Connectionis only used inquickckecktest, thus moved intoquickchecktest.PendingConnectionis only used inmax_circuit_durationtest, thus moved intomax_circuit_durationtest.
thomaseizinger
approved these changes
Apr 11, 2023
|
|
||
| #[test] | ||
| fn forward_data_should_flush_on_pending_source() { | ||
| struct NeverEndingSource { |
There was a problem hiding this comment.
Suggested change
| struct NeverEndingSource { | |
| struct NeverEndingStory { |
Comment on lines
+383
to
+385
| "Given that destination is wrapped with a `BufWrite`, the write doesn't (yet) make it to \ | ||
| the destination. The source might have more data available, thus `forward_data` has not \ | ||
| yet flushed.", |
There was a problem hiding this comment.
Suggested change
| "Given that destination is wrapped with a `BufWrite`, the write doesn't (yet) make it to \ | |
| the destination. The source might have more data available, thus `forward_data` has not \ | |
| yet flushed.", | |
| "Expect BufWriter to still have space and thus not forward the poll_write call", |
thomaseizinger
changed the title
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
|
|
|
//CC @p-shahi for visibility for the universal connectivity project. |
This was referenced Apr 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a relay, when forwarding data between relay-connection-source and -destination and vice versa, flush write side when read currently has no more data available.
Notes & open questions
Credit goes to @MarcoPolo for discovering this!
Change checklist