refactor(noise): implement tests using futures_ringbuf
#3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft because it is a staked PR. |
`pub type` aliases don't export the enum contructors unfortunately.
This comment was marked as resolved.
This comment was marked as resolved.
thomaseizinger
added
send-it
trivial
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of creating a connection via a TCP transport, we can use the
futures_ringbufcrate and run the noise encryption on an in-memory transport. This removes the dependency on thelibp2p_core::upgrade::applyfunction and takes less code to implement.Related #3748.
Notes & open questions
Change checklist