refactor(identify): bring tests up to workspace standard #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now included in the smoke test
These files are not included in the module tree.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏 |
mxinden
previously approved these changes
May 4, 2023
4 tasks
mxinden
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch refactors the identify tests to use
libp2p-swarm-test. This allows us to delete quite a bit of code and makes several dev-dependencies obsolete.The
correct_transfertest is made obsolete by more precise assertions in theperiodic_identifytest. This allows us to remove the dependency on theupgrade::{apply_inbound,apply_outbound}functions.Finally, we also fix a bug where the reported listen addresses to the other node could contain duplicates.
Related: #3748.
Notes & open questions
Patch-by-patch review is recommended.
We could split this into multiple PRs, I am not yet sure it is worth it.
Change checklist