Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(swarm): better error message for failed DialPeerConditions #4409

Merged
merged 10 commits into from
Sep 6, 2023
Merged

fix(swarm): better error message for failed DialPeerConditions #4409

merged 10 commits into from
Sep 6, 2023

Conversation

chirag-bgh
Copy link
Contributor

@chirag-bgh chirag-bgh commented Aug 29, 2023 •
edited by thomaseizinger
Loading

Description

Closes #4407.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

mxinden
mxinden reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for starting this. There is more needed I am afraid.

swarm/src/lib.rs Outdated Show resolved Hide resolved
mxinden
mxinden reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller nit picks. This looks good overall. Thank you for the work.

swarm/src/lib.rs Outdated Show resolved Hide resolved
swarm/src/lib.rs Outdated Show resolved Hide resolved
chirag-bgh and others added 4 commits September 4, 2023 18:56
@chirag-bgh @mxinden
Update swarm/src/lib.rs
7b369ea 
Co-authored-by: Max Inden <mail@max-inden.de>
@chirag-bgh @mxinden
Update swarm/src/lib.rs
33a4cca 
Co-authored-by: Max Inden <mail@max-inden.de>
@chirag-bgh
Merge branch 'master' into swarm_error_msg
597ddb6
@chirag-bgh
fix
8922d10
thomaseizinger
thomaseizinger reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We will also need a version bump of libp2p-swarm and a changelog entry.

swarm/src/lib.rs Outdated Show resolved Hide resolved
thomaseizinger
thomaseizinger reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

swarm/CHANGELOG.md Outdated Show resolved Hide resolved
swarm/CHANGELOG.md Outdated Show resolved Hide resolved
swarm/CHANGELOG.md Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title fix(swarm): improve error message on false DialPeerCondition fix(swarm): improve error message when DialPeerCondition prevents a dial. Sep 5, 2023
@thomaseizinger thomaseizinger changed the title fix(swarm): improve error message when DialPeerCondition prevents a dial. fix(swarm): improve error message when DialPeerCondition prevents a dial Sep 5, 2023
thomaseizinger
thomaseizinger previously approved these changes Sep 5, 2023
View reviewed changes
swarm/CHANGELOG.md Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title fix(swarm): improve error message when DialPeerCondition prevents a dial fix(swarm): better error message for failed DialPeerConditions Sep 6, 2023
@mergify mergify bot dismissed thomaseizinger’s stale review September 6, 2023 11:36

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify mergify bot merged commit 94a136c into libp2p:master Sep 6, 2023
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden Awaiting requested review from mxinden

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(swarm): improve error message on false DialPeerCondition
3 participants
@chirag-bgh @thomaseizinger @mxinden