Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(libp2p): add shortcut with_tcp(...).with_bandwidth_logging() #4626

Merged
merged 4 commits into from
Oct 13, 2023
Merged

fix(libp2p): add shortcut with_tcp(...).with_bandwidth_logging() #4626

merged 4 commits into from
Oct 13, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Oct 11, 2023

Description

Add the shortcut method .with_bandwidth_logging to SwarmBuilder<_, QuicPhase<_>>, thus allowing with_tcp(...).with_bandwidth_logging().

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden
fix(SwarmBuilder): add shortcut with_tcp(...).with_bandwidth_logging()
72d4fde 
Add the shortcut method `.with_bandwidth_logging` to `SwarmBuilder<_, QuicPhase<_>>`, thus allowing
`with_tcp(...).with_bandwidth_logging()`.
@mxinden
Clippy
da4d691
@mxinden
fmt
1d895ba
@thomaseizinger thomaseizinger changed the title fix(SwarmBuilder): add shortcut with_tcp(...).with_bandwidth_logging() fix(libp2p): add shortcut with_tcp(...).with_bandwidth_logging() Oct 11, 2023
@mxinden mxinden mentioned this pull request Oct 13, 2023
Open
@mergify mergify bot merged commit 74c087d into libp2p:master Oct 13, 2023
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxinden @thomaseizinger