feat(swarm): add peer_id to ListenFailure
#4818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
force-pushed
the
feat/listenfailure-peer-id
branch
from
e0d9325
to
99fdde6
Compare
There was a problem hiding this comment.
Thanks! This is a breaking change so'll have to hold off on it for a while. I hope that is okay. #4777 is not blocked on this as far as I understand because ConnectionIds are unique across peers so we should be able to clean up state properly!
nathanielc
force-pushed
the
feat/listenfailure-peer-id
branch
from
99fdde6
to
817aa04
Compare
It's possible in certain failure modes to know the peer_id of a failed incoming connection. For example when an inbound connection has been negotiated/upgraded but then rejected locally for a connection limit or similar reason. In these cases it makes sense to communicate the peer_id to behaviours in case they have created any internal state about the peer.
nathanielc
force-pushed
the
feat/listenfailure-peer-id
branch
from
817aa04
to
8c4e6bd
Compare
Yep all good,no rush on this feature from us. |
thomaseizinger
changed the title
peer_id to ListenFailure
4 tasks
|
This pull request has merge conflicts. Could you please resolve them @nathanielc? 🙏 |
jxs
force-pushed
the
feat/listenfailure-peer-id
branch
from
7f95df7
to
560a12a
Compare
TimTinkers
pushed a commit
to unattended-backpack/rust-libp2p
that referenced
this pull request
Sep 14, 2024
It's possible in certain failure modes to know the peer_id of a failed incoming connection. For example when an inbound connection has been negotiated/upgraded but then rejected locally for a connection limit or similar reason. In these cases it makes sense to communicate the peer_id to behaviours in case they have created any internal state about the peer. Related libp2p#4777 Pull-Request: libp2p#4818.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's possible in certain failure modes to know the peer_id of a failed incoming connection. For example when an inbound connection has been negotiated/upgraded but then rejected locally for a connection limit or similar reason. In these cases it makes sense to communicate the peer_id to behaviours in case they have created any internal state about the peer.
Related #4777
Notes & open questions
Change checklist