Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed at the last maintainer call @jxs, I'm upstreaming our work on UPNP.
Our work began to allow us to listen on the unspecified address which was not working correctly since a single
ListenerId
can give multiple listen addresses and this was not correctly handled in the UPNP behaviour. However we also experienced somePending
blocking for ever but I don't remember the exact cause. That's why we ended up doing a more important change that we had expected. We also removed custom events from UPNP to replace them with the genericExternalAddrConfirmed
andExternalAddrExpired
.This PR wants to be a starting point to integrate this work. IMHO, I don't thinks it is ready to merge as is, that's why I'm opening this so we can discuss what could/should be integrated and what should not.
As I have also mentioned during the call, there is some know issues:
Notes & open questions
N/A
Change checklist