Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quic): allow setting the MTU discovery upper bound #5386

Merged
merged 5 commits into from
May 14, 2024

Conversation

Wiezzel
Copy link
Contributor

@Wiezzel Wiezzel commented May 14, 2024

Description

The default MTU discovery upper bound is too high for some environments and results in permanent warnings. As I'd like to be able to configure this setting, adding a new method for the Config.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@Wiezzel
Copy link
Contributor Author

Wiezzel commented May 14, 2024

@jxs

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Adam, left a comment

transports/quic/src/config.rs Outdated Show resolved Hide resolved
@Wiezzel Wiezzel requested a review from jxs May 14, 2024 15:37
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

transports/quic/src/config.rs Outdated Show resolved Hide resolved
@jxs jxs changed the title feat(quic): allow setting MtuDiscoveryConfig feat(quic): allow setting the MTU discovery upper bound May 14, 2024
@jxs jxs added the send-it label May 14, 2024
@mergify mergify bot merged commit 1aa016e into libp2p:master May 14, 2024
74 checks passed
jxs pushed a commit to retrohacker/rust-libp2p that referenced this pull request May 14, 2024
The default MTU discovery upper bound is too high for some environments and results in permanent warnings. As I'd like to be able to configure this setting, adding a new method for the `Config`.

Pull-Request: libp2p#5386.
jxs pushed a commit to retrohacker/rust-libp2p that referenced this pull request May 14, 2024
The default MTU discovery upper bound is too high for some environments and results in permanent warnings. As I'd like to be able to configure this setting, adding a new method for the `Config`.

Pull-Request: libp2p#5386.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants