Path 2: update rcgen to version 0.13.1 #5592
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #5590 this PR shows all the necessary changes for update path 2.
In this solution, rcgen and webrtc is updated to the newest version which makes substantial code changes necessary.
Notes & open questions
I do not know the code base well enough to make sure I did not break anything here. All the tests (minus doc test) work and I also built lighthouse which depends on libp2p2-tls and it works flawlessly, so I do not think I broke anything obvious.
I did not change the documentation which is why doctest tests fail.
Change checklist
I did not do the changes described below. I can do this once it is decided which update Path is the one to go.