Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a section about a new muxer to the README #395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marten-seemann
Copy link
Contributor

No description provided.


**What?** A stream multiplexer that supports:
- backpressure on the stream level (stream flow control)
- backpressure on the connection level connection flow control)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- backpressure on the connection level connection flow control)
- backpressure on the connection level (connection flow control)
Suggested change
- backpressure on the connection level connection flow control)
- backpressure on the connection level connection flow control)

**Why?** So far, we've been using yamux and mplex as stream multiplexers.
Shortcomings in those protocols have made our stack less robust than it
could be.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about linking #394 here?

**Why?** So far, we've been using yamux and mplex as stream multiplexers.
Shortcomings in those protocols have made our stack less robust than it
could be.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about linking #394 here?

@@ -222,6 +222,17 @@ model.

This is the stuff pushing the existing libp2p stack forward.

### A robust stream multiplexer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving this below "Low latency, efficient connection handshake". What do you think?

@@ -222,6 +222,17 @@ model.

This is the stuff pushing the existing libp2p stack forward.

### A robust stream multiplexer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving this below "Low latency, efficient connection handshake". What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

2 participants