fix(interop): rename webrtc to webrtc-direct
#166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See multiformats/multiaddr#150 (comment) for context on discussion. - Renames the `webrtc` transport identifier to `webrtc-direct`. - Re-enables `webrtc-direct` support for rust-libp2p v0.51. Previously disabled in libp2p#160. See libp2p/rust-libp2p#3781 for corresponding change on the rust-libp2p side. - Leaves JS v0.41 and v0.42 untouched. To be done in a follow-up alongside JS dependency updates.
thomaseizinger
approved these changes
Apr 12, 2023
4 tasks
MarcoPolo
approved these changes
Apr 15, 2023
| @@ -61,7 +61,7 @@ export async function buildTestSpecs(versions: Array<Version>): Promise<Array<Co | |||
| AND ma.muxer == mb.muxer | |||
| -- quic only uses its own muxer/securechannel | |||
| AND a.transport != "webtransport" | |||
| AND a.transport != "webrtc" | |||
There was a problem hiding this comment.
we want both here, right? but not needed right now
There was a problem hiding this comment.
We'll add this when we add webrtc tests here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See multiformats/multiaddr#150 (comment) for context on discussion.
webrtctransport identifier towebrtc-direct.webrtc-directsupport for rust-libp2p v0.51. Previously disabled in fix(versions): disable webrtc tests #160. See fix(interop): usewebrtc-directas browser-to-server identifier rust-libp2p#3781 for corresponding change on the rust-libp2p side.