perf: simplify go-libp2p and https implementation #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
approved these changes
Jun 22, 2023
Comment on lines
+59
to
70
| func (r *nullReader) Read(b []byte) (int, error) { | ||
| remaining := r.N - r.read | ||
| l := uint64(len(b)) | ||
| if uint64(len(b)) > remaining { | ||
| l = remaining | ||
| } | ||
| return b | ||
| r.read += l | ||
| if r.read == r.N { | ||
| return int(l), io.EOF | ||
| } | ||
| return int(l), nil | ||
| } |
There was a problem hiding this comment.
I am assuming that it is safe in Golang to return "uninitialized" bytes, i.e. the original bytes in b to a remote machine. E.g. there is no risk of b containing deallocated secret key material.
Just for others, returning non-zero bytes is just fine according to the perf specification:
The bytes themselves should be a predetermined arbitrary set of bytes. Zero is fine, but so is random bytes (as long as it's not a different set of random bytes, because then you may be limited by how fast you can generate random bytes).
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of nits. The biggest change here is that I refactored
sendBytesanddrainStreaminto pure functions, and copy-pasted them into the https implementation. Using anio.MultiReaderallows us to simplify the reading of thehttp.Request.Body.@mxinden Feel free to merge (this is targeting #184). Does this PR trigger a CI run? Would be good in order to see if this actually works.