Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Proxy support #295

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

tyronewyatt
Copy link

I logged a issue #289 as https://ipinfo.io/ request would time out, This was causing the speedtest to hang for 60 seconds before it would start. HTTP/HTTPS is blocked in my environments and we are forced to make web requests via http proxy. Setting the system proxy fails to make any difference on my web servers.

As such, I have created proxy support in my fork.

Tested with proxy address set and blank, OK.

PS, I'm a sys admin, not a dev.

@sveken
Copy link

sveken commented Apr 2, 2020

Thank you, just what i needed in my envoirment too,

@sstidl sstidl self-assigned this Nov 4, 2023
Copy link
Collaborator

@sstidl sstidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New variables must be handled in

  • entrypoint.sh
  • documentation

@@ -79,11 +79,15 @@ function getIpInfoTokenString(){
if(empty($IPINFO_APIKEY)) return "";
return "?token=".$IPINFO_APIKEY;
}
$httpproxyFile="getIP_ipInfo_httpproxy.php";
if (!file_exists($httpproxyFile)) return "";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why return here?
The missing file should be handled as if no proxy defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants