Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hyper-rustls to 0.27 and adjust CI workflow #1318

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

yubiuser
Copy link
Contributor

@yubiuser yubiuser commented Aug 29, 2024

Updates hyper-rustls > 0.27 changed it's backend to aws-lc-rs which requires changes to the build environment.

  1. On windows test this was pretty simple, only change was addition of NASM
  2. The linux cross compilation failed using cross. cross setups a docker based build environment and despite trying hard I could not get it building the armv7 binary (mainly, because bindgen is required to build aws-lc-rs which could not be build successful within the container). Therefore, I decided to replace cross with native cargo cross-compilation support which is not only faster, easier to debug but also got the binary build easily.

Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
@roderickvd roderickvd merged commit e9234d3 into librespot-org:dev Sep 5, 2024
8 of 9 checks passed
@roderickvd
Copy link
Member

Thanks for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants