macOS: use IORegistryEntryGetRegistryEntryID to resolve paths #322
+51
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some device connection configurations, the device paths become over 512 bytes (io_string_t max length) which makes them unusable with current implementation. Rather than using ServiceRegistry string path, use its ID, which is uint64_t and easily serializable/deserializable into a string. Implementation idea by felix.schwarz@iospirit.com flirc/hidapi@8d251c3 Fixes: #127, #236.
|
@erikmwerner, @mcuee will you be able to try this out? |
|
This seems to work fine. Without this pull request, it is problematic for my setup whhere I have two powered hub (which are nested hub themselves). |
mcuee
approved these changes
Aug 15, 2021
|
@Youw Is it possible to integrate this patch with the branch https://github.com/libusb/hidapi/tree/get-descriptor? Or what is the simple way for me to merge this patch with my local repo? Sorry I am not good at using git. Or maybe the other way around, integrate get-descriptor branch to the main branch. |
|
Not so sure if the following is the correct way. |
This was referenced Aug 25, 2021
Technically we want to "sync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some device connection configurations,
the device paths become over 512 bytes (io_string_t max length)
which makes them unusable with current implementation.
Rather than using ServiceRegistry string path, use its ID,
which is uint64_t and easily serializable/deserializable into a string.
Implementation idea by felix.schwarz@iospirit.com
flirc/hidapi@8d251c3
Fixes: #127, #236.