Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.12.0-RC1 found fixes #409

Merged
merged 2 commits into from
May 5, 2022
Merged

v0.12.0-RC1 found fixes #409

merged 2 commits into from
May 5, 2022

Conversation

Youw
Copy link
Member

@Youw Youw commented May 4, 2022

No description provided.

Youw added 2 commits May 4, 2022 14:33
@Youw
Use propper type for mach_port_t default param
f950a6a 
- enable compilation warnings as errors for CI to catch such issues in the future;
- fix Mingw strict compilation warnings;
@Youw
Fix hidtest build
9ab5a9f 
- fix including platform-specific includes when HIDAPI is a CMake subdirectory;
- check libusb and winapi platform-specific headers with hidtest;
@Youw Youw mentioned this pull request May 4, 2022
Closed
@mcuee mcuee added build system/CI Anything related to building the project or running on CI macOS Related to macOS backend labels May 5, 2022
@mcuee
Copy link
Member

mcuee commented May 5, 2022

Tested to be okay under macOS. No more warnings and hidtest build is okay.

mcuee
mcuee approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@mcuee mcuee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But I am probably not a good reviewer for all the changes. So it is better to have one more approval.

@Youw
Copy link
Member Author

Youw commented May 5, 2022

I am probably not a good reviewer

well:

Tested to be okay under macOS.

That matters a lot.

@Youw Youw merged commit c95795a into master May 5, 2022
@Youw Youw deleted the mac_fix branch May 5, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcuee mcuee mcuee approved these changes

Assignees
No one assigned
Labels
build system/CI Anything related to building the project or running on CI macOS Related to macOS backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Youw @mcuee