Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to bring ember-data #29

Merged
merged 21 commits into from
Jul 12, 2023
Merged

attempt to bring ember-data #29

merged 21 commits into from
Jul 12, 2023

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jan 13, 2023

Resolves: #16

In short, we able to fix main breakage using following steps:

  • override ember-data-private-build-infra
  • patching getOwnConfig
  • configuring vite to optimizeDeps.exclude: ['@ember-data/store'] (loosing symbols)
  • adding @babel/plugin-transform-typescript to build not-builded e-data deps

@lifeart lifeart added the help wanted Extra attention is needed label Jan 13, 2023
@lifeart lifeart changed the title attempt to bing ember-data attempt to bring ember-data Jan 13, 2023
@lifeart
Copy link
Owner Author

lifeart commented Jan 15, 2023

tldr: error simplified to
image

@lifeart
Copy link
Owner Author

lifeart commented Jan 18, 2023

V2 addons should be helpful here, linking: emberjs/data#8103

In addition, we could try https://www.npmjs.com/package/@rollup/plugin-virtual for better debugging..

@runspired
Copy link

we're close to being able to ship v2 addons, only 2 bugs left in embroider for us to be able to do so.

@lifeart
Copy link
Owner Author

lifeart commented Jul 12, 2023

@runspired sorry to bothering you here, is it possible (in theory), to get ember-data working at this point (without embroider)?

Looks like it's working! I'm looking forward for new ember-data usage suggestions here

At the moment there is strange babel decorator erros, related to it.

Maybe we need extra love here:

node_modules/@ember-data/private-build-infra/src/transforms
@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for ember-vite ready!

Name Link
🔨 Latest commit afe51ea
🔍 Latest deploy log https://app.netlify.com/sites/ember-vite/deploys/64aec5f2ff01d700085afaf3
😎 Deploy Preview https://deploy-preview-29--ember-vite.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lifeart
Copy link
Owner Author

lifeart commented Jul 12, 2023

finally,
image

@lifeart lifeart marked this pull request as ready for review July 12, 2023 12:18
@lifeart lifeart requested a review from kaermorchen July 12, 2023 12:18
@github-actions
Copy link

github-actions bot commented Jul 12, 2023

Code Coverage Report

Coverage after merging ember-data into master

99.86%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
addons
   ember-simple-auth.ts12, 16
.../Bootstrap
   index.ts50
config
   registry.ts83, 97
   router.ts98.0897, 98
helpers
   memory-usage.ts12, 18, 20, 30, ...
modifiers
   click-tracker.ts20, 21

@lifeart
Copy link
Owner Author

lifeart commented Jul 12, 2023

Looks like we have prod build issues here (netlify preview)
image
image

image

@lifeart lifeart merged commit 331aa03 into master Jul 12, 2023
9 checks passed
@lifeart lifeart deleted the ember-data branch July 12, 2023 15:29
@lifeart lifeart restored the ember-data branch July 12, 2023 19:27
@lifeart lifeart deleted the ember-data branch December 9, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ember-data support
2 participants