Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get ember 5 working #53

Merged
merged 1 commit into from
Jul 13, 2023
Merged

get ember 5 working #53

merged 1 commit into from
Jul 13, 2023

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jul 13, 2023

In general, all working fine.

  1. Given priority to ember-source/dist/dependencies/@glimmer/
  2. Added @ember/string for ember-resolver
  3. Updated ember-source patch (because file changes)
  4. Bumped deps, related to @ember/string

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for ember-vite ready!

Name Link
🔨 Latest commit 0743033
🔍 Latest deploy log https://app.netlify.com/sites/ember-vite/deploys/64b011da93425b000858da15
😎 Deploy Preview https://deploy-preview-53--ember-vite.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Code Coverage Report

Coverage after merging ember-5 into master

99.86%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
addons
   ember-simple-auth.ts12, 16
.../Bootstrap
   index.ts50
config
   registry.ts83, 97
   router.ts98.0897, 98
helpers
   memory-usage.ts12, 18, 20, 30, ...
modifiers
   click-tracker.ts20, 21

@lifeart lifeart merged commit 055e4ed into master Jul 13, 2023
9 checks passed
@lifeart lifeart deleted the ember-5 branch July 13, 2023 15:05
@lifeart lifeart mentioned this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant