Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPD-28466 - Products' ERC cannot be updated with PATCH by external reference code #5080

Closed
wants to merge 3 commits into from
Closed

LPD-28466 - Products' ERC cannot be updated with PATCH by external reference code #5080

wants to merge 3 commits into from

Conversation

victorcdp
Copy link

@victorcdp victorcdp commented Jun 25, 2024 •
edited
Loading

Resend of #5048

https://liferay.atlassian.net/browse/LPD-28466

@andrea-ale-sbarra Can you review this? Tied to an LPP. Thank you!

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@brianikim
Copy link

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 24e74622b8672271815a9d7c52569058b9ac5b8d

Sender Branch:

Branch Name: LPD-28466
Branch GIT ID: 478f8f0565ac63fbeef0e4a15c019dfd6467a53d

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@brianikim
Copy link

ci:test:relevant

@brianikim
Copy link

ci:test:commerce-functional

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:commerce-functional - 196 out of 208 jobs passed in 1 hour 57 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1407401_10321

Base Branch:

Branch Name: master
Branch GIT ID: f70e314f67dca8dbc899bff1669d39637e7c0e5a

Upstream Comparison:

Branch GIT ID: 7ad7570343ecae9b7ca0930e20480b25a2328956
Jenkins Build URL: EE Development Acceptance (master) - 672 - 2024-07-14[12:38:05]

ci:test:commerce-functional - 196 out of 208 jobs PASSED

12 Failed Jobs:

196 Successful Jobs:
    For more details click here.

    Failures unique to this pull:

    1. source-format-current-branch-jdk8/0/0
      clean-up-java-processes:
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/clean_up_java_processes.sh
     [echo] run.batch.test.setup.start.timestamp: 07-15-2024 08:30:15:544 PDT
[stopwatch] [run.batch.test.setup: 0.000 sec]
     [echo] run.batch.test.action.start.timestamp: 07-15-2024 08:30:15:545 PDT
[stopwatch] [run.batch.test.action: 0.003 sec]
     [echo] exec returned: 128
      [get] Getting: \$\{dependencies.url\}/archive/test-1-29/test-portal-acceptance-pullrequest-downstream(master)/939334consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20240715083015549.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20240715083015549.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null2130772507.properties
      1. com.liferay.jenkins.JenkinsLogAsserterTest
    6. ...

    For upstream results, click here.

    @liferay-continuous-integration
    Copy link
    Collaborator

    @liferay-continuous-integration
    Copy link
    Collaborator

    ✔️ ci:test:stable - 31 out of 31 jobs passed

    ✔️ ci:test:relevant - 52 out of 54 jobs passed in 2 hours 14 minutes

    Click here for more details.

    Base Branch:

    Branch Name: master
    Branch GIT ID: f70e314f67dca8dbc899bff1669d39637e7c0e5a

    Upstream Comparison:

    Branch GIT ID: 7ad7570343ecae9b7ca0930e20480b25a2328956
    Jenkins Build URL: EE Development Acceptance (master) - 672 - 2024-07-14[12:38:05]

    ci:test:stable - 31 out of 31 jobs PASSED
    31 Successful Jobs:
      ci:test:relevant - 51 out of 54 jobs PASSED

      3 Failed Jobs:

      51 Successful Jobs:
        For more details click here.

        This pull contains no unique failures.

        Failures in common with acceptance upstream results at 7ad7570:

        @liferay-continuous-integration
        Copy link
        Collaborator

        andrea-ale-sbarra
        andrea-ale-sbarra approved these changes Jul 22, 2024
        View reviewed changes
        Copy link
        Collaborator

        @andrea-ale-sbarra andrea-ale-sbarra left a comment

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        LGTM.
        Thank you!

        @andrea-ale-sbarra
        Copy link
        Collaborator

        ci:forward

        @liferay-continuous-integration
        Copy link
        Collaborator

        CI is automatically triggering the following test suites:

        •     ci:test:relevant
        •     ci:test:sf
        •     ci:test:stable

        The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

        •     ci:test:relevant
        •     ci:test:sf
        •     ci:test:stable

        @liferay-continuous-integration
        Copy link
        Collaborator

        Skipping previously passed test suites:

        • ci:test:relevant
        • ci:test:sf
        • ci:test:stable

        @liferay-continuous-integration
        Copy link
        Collaborator

        All required test suite(s) passed.
        Forwarding pull request to brianchandotcom.
        Console

        Closed
        @liferay-continuous-integration
        Copy link
        Collaborator

        Pull request has been successfully forwarded to brianchandotcom#152545
        Console

        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Reviewers

        @andrea-ale-sbarra andrea-ale-sbarra andrea-ale-sbarra approved these changes

        @riccardo-alberti riccardo-alberti riccardo-alberti approved these changes

        Assignees
        No one assigned
        Labels
        ci:test:commerce-functional - failure ci:test:relevant - success ci:test:sf - success ci:test:stable - success
        Projects
        None yet
        Milestone
        No milestone
        5 participants
        @victorcdp @liferay-continuous-integration @brianikim @andrea-ale-sbarra @riccardo-alberti