Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike: get eslint v9 working #235

Closed
wants to merge 1 commit into from
Closed

spike: get eslint v9 working #235

wants to merge 1 commit into from

Conversation

DNR500
Copy link
Contributor

@DNR500 DNR500 commented Apr 15, 2024

I’ve been hacking away at tying to get the eslint v9 set up working In the widget codebase - specifically I was spiking out the new Eslint in the widget package listing again.

Main problem I was having was with eslint-config-react-app and I can’t get that to work at all - not even when using with using some of the tooling eslint provides to help migrate legacy config.

Some of the other config and plugin tools have been updated - for example eslint-plugin-prettier has documentation for the new “flat config” style for eslint and its easy to get those working.

I couldn’t find anything about ‘‘eslint-config-react-app’ using the new eslint flat config - its not been published in a couple of years and we might have to seriously think about moving away from it. I started to take a look at the plugins and config it uses under the hood - some have already adopted support for flat config, such as eslint-plugin-react, but others are still implementing support, for example eslint-plugin-react-hooks is maintained by the React team and they still have an open PR for supporting the new config style for eslint.

@DNR500 DNR500 added the WIP Work in progress label Apr 15, 2024
@DNR500
Copy link
Contributor Author

DNR500 commented Apr 16, 2024

This was just created to record my findings and does need to be merged in so I'm closing it

@DNR500 DNR500 closed this Apr 16, 2024
@chybisov chybisov deleted the fix-for-eslint-v9 branch July 8, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant