Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Fan-Out Support #1

Merged
merged 24 commits into from
Nov 27, 2018
Merged

Enhanced Fan-Out Support #1

merged 24 commits into from
Nov 27, 2018

Conversation

eaviles
Copy link
Member

@eaviles eaviles commented Sep 20, 2018

Work in progress branch and pull request for introducing support for enhanced fan-out consumers.

@codecov-io
Copy link

codecov-io commented Sep 24, 2018

Codecov Report

Merging #1 into develop will decrease coverage by 31.94%.
The diff coverage is 68.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop       #1       +/-   ##
============================================
- Coverage      100%   68.05%   -31.95%     
============================================
  Files            1        7        +6     
  Lines            1      216      +215     
  Branches         0       31       +31     
============================================
+ Hits             1      147      +146     
- Misses           0       57       +57     
- Partials         0       12       +12
Impacted Files Coverage Δ
lib/consumer.js 100% <100%> (ø)
lib/utils.js 100% <100%> (ø)
lib/records-decoder.js 15.62% <15.62%> (ø)
lib/shard-subscriber.js 25% <25%> (ø)
lib/compression.js 33.33% <33.33%> (ø)
lib/stream.js 92.72% <92.72%> (ø)
lib/index.js 96.96% <96.96%> (-3.04%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f49fbd...b5b9ce1. Read the comment docs.

@eaviles eaviles requested a review from srdjan September 25, 2018 20:44
@eaviles eaviles self-assigned this Sep 26, 2018
nemx
nemx previously approved these changes Oct 12, 2018
@eaviles eaviles merged commit e074ce2 into develop Nov 27, 2018
@eaviles eaviles deleted the feature/enhanced-fan-out branch November 29, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants