Add retry to putRecord(s) #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaviles
previously approved these changes
Apr 23, 2019
There was a problem hiding this comment.
Something to think about, do we want to retry on any error? Is there any chance a record is actually sent but we get like a "network" disconnected error and we end up sending the same record twice? Do we want to instead retry on the errors we know? (throughput exceptions, etc)
kenzable
commented
Apr 23, 2019
lib/kinesis-client.js
Outdated
| .putRecord(...args) | ||
| .promise() | ||
| .catch(err => { | ||
| if (shouldBailRetry(err)) bail(err); |
There was a problem hiding this comment.
Only retry if throughput exception.
kenzable
commented
Apr 23, 2019
lib/kinesis-client.js
Outdated
| throw errObj; | ||
| }) | ||
| .catch(err => { | ||
| if (shouldBailRetry(err)) bail(err); |
There was a problem hiding this comment.
Only retry on throughput exception.
eaviles
approved these changes
Apr 23, 2019
kenzable
deleted the
feature/implement-write-retry-on-throughput-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.