Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add stats and health #115

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Feature/add stats and health #115

merged 2 commits into from
Apr 26, 2019

Conversation

kenzable
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #115 into develop will increase coverage by 0.08%.
The diff coverage is 8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #115      +/-   ##
=========================================
+ Coverage     9.11%   9.2%   +0.08%     
=========================================
  Files           13     14       +1     
  Lines         1020   1141     +121     
  Branches       138    149      +11     
=========================================
+ Hits            93    105      +12     
- Misses         791    889      +98     
- Partials       136    147      +11
Impacted Files Coverage Δ
lib/kinesis-client.js 2.82% <1.69%> (-0.08%) ⬇️
lib/dynamodb-client.js 6.06% <10%> (+1.4%) ⬆️
lib/stats.js 11.66% <11.66%> (ø)
lib/index.js 17.64% <12.5%> (-0.08%) ⬇️
lib/fan-out-consumer.js 16.51% <33.33%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09708ff...9a6d906. Read the comment docs.

const Cache = require('lru-cache');
const { version } = require('../package.json');

const FIVE_MINS = 5 * 60 * 1000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's work on making this configurable.

@eaviles eaviles merged commit 7c6d096 into develop Apr 26, 2019
@eaviles eaviles deleted the feature/add-stats-and-health branch April 26, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants