Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/enhanced consumers assign conflict #208

Merged
merged 8 commits into from
Aug 21, 2019
Merged

Bugfix/enhanced consumers assign conflict #208

merged 8 commits into from
Aug 21, 2019

Conversation

eaviles
Copy link
Member

@eaviles eaviles commented Aug 21, 2019 •
edited
Loading

This PR fixes 3 issues:

  1. When releasing enhanced fan-out consumers it would override the ones already in use.
  2. Improves locking an enhanced fan-out-consumer by ensuring only unused consumers are successfully locked.
  3. All the exceptions thrown from timer callbacks are caught.

Fixes #153

Still pending to do:

  • Fix broken tests
  • Recover test coverage

@eaviles eaviles marked this pull request as ready for review August 21, 2019 07:44
chendoron
chendoron approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@chendoron chendoron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@eaviles eaviles merged commit 760ed4c into develop Aug 21, 2019
@eaviles eaviles deleted the bugfix/enhanced-consumers-assign-conflict branch August 21, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chendoron chendoron chendoron approved these changes

@kenzable kenzable Awaiting requested review from kenzable

@zaid-lifion zaid-lifion Awaiting requested review from zaid-lifion

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple enhanced fanout issue
2 participants
@eaviles @chendoron