Fix conflicts when aborting the pipeline #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted with the latest Got module
Codecov Report
@@ Coverage Diff @@
## develop #287 +/- ##
======================================
Coverage 100% 100%
======================================
Files 18 18
Lines 1327 1340 +13
Branches 181 183 +2
======================================
+ Hits 1327 1340 +13
Continue to review full report at Codecov.
|
jennyEckstein
approved these changes
Feb 5, 2020
jennyEckstein
deleted the
bugfix/enhanced-consumers-stop-receiving-records
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timer inside a pipeline that ensures data is timely coming from AWS would abort a subsequent request by mistake. Also, aborting a request with the latest Got module wasn't really working properly as the pipeline would stay open.
This fixes #216