Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed following MSVC warning/errors when compiled as C source: #6

Closed
wants to merge 1 commit into from
Closed

Fixed following MSVC warning/errors when compiled as C source: #6

wants to merge 1 commit into from

Conversation

r-lyeh
Copy link

@r-lyeh r-lyeh commented Sep 19, 2022 •
edited
Loading

  • error C2057: expected constant expression
  • error C2059: syntax error: '{}'
  • error C2065: 'sample11': undeclared identifier
  • error C2133: 'distance_rows': unknown size
  • error C2466: cannot allocate an array of constant size 0
  • warning C4098: 'j40__add_thresholds': 'void' function returning a value
  • warning C4098: 'j40__forward_dct_unscaled': 'void' function returning a value
  • warning C4098: 'j40__inverse_dct': 'void' function returning a value
  • warning C4141: 'inline': used more than once
  • I agree to publish my contributions to the public domain and in any public-domain equivalent license described in LICENSE.txt.

@r-lyeh
Fixed following MSVC warning/errors when compiled as C source:
d1aa9b1 
- error C2057: expected constant expression
- error C2059: syntax error: '{}'
- error C2065: 'sample11': undeclared identifier
- error C2133: 'distance_rows': unknown size
- error C2466: cannot allocate an array of constant size 0
- warning C4098: 'j40__add_thresholds': 'void' function returning a value
- warning C4098: 'j40__forward_dct_unscaled': 'void' function returning a value
- warning C4098: 'j40__inverse_dct': 'void' function returning a value
- warning C4141: 'inline': used more than once
@r-lyeh
Copy link
Author

r-lyeh commented Sep 19, 2022

Feel free to discard completely and/or cherry-pick fixes from this. Amazing project btw!

@lifthrasiir lifthrasiir self-assigned this Sep 19, 2022
@lifthrasiir
Copy link
Owner

Thank you for PR. It took a while because I had to make the build system fully support Windows (please tell me whether make works out of the box or not!). I incorporated your changes as 501f733 except for _lzcnt_u32/64, which is a machine intrinsic and should not be used in a portable code and I rewrote that part in 095f4a3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lifthrasiir lifthrasiir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-lyeh @lifthrasiir