Skip to content

Commit

Permalink
ethclient: ensure the close of canceled context (ethereum#28349)
Browse files Browse the repository at this point in the history
  • Loading branch information
keroro520 committed Oct 17, 2023
1 parent 1b1611b commit 1f11d2d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions ethclient/ethclient_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ func testTransactionInBlockInterrupted(t *testing.T, client *rpc.Client) {
// Test tx in block interrupted.
ctx, cancel := context.WithCancel(context.Background())
cancel()
<-ctx.Done() // Ensure the close of the Done channel
tx, err := ec.TransactionInBlock(ctx, block.Hash(), 0)
if tx != nil {
t.Fatal("transaction should be nil")
Expand Down Expand Up @@ -666,6 +667,7 @@ func testTransactionSender(t *testing.T, client *rpc.Client) {
// TransactionSender. Ensure the server is not asked by canceling the context here.
canceledCtx, cancel := context.WithCancel(context.Background())
cancel()
<-canceledCtx.Done() // Ensure the close of the Done channel
sender1, err := ec.TransactionSender(canceledCtx, tx1, block2.Hash(), 0)
if err != nil {
t.Fatal(err)
Expand Down

0 comments on commit 1f11d2d

Please sign in to comment.