Fix: getAllCIDs index out of bound issue #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 12, 2023 13:52
ravish1729
reviewed
Oct 12, 2023
contracts/mocks/DealStatusMock.sol
Outdated
| @@ -96,11 +100,21 @@ contract DealStatusMock is IAggregatorOracle, ProofMock { | |||
| // get the deal's expiration epoch | |||
| MarketTypes.GetDealTermReturn memory dealTerm = MarketAPI.getDealTerm(dealId); | |||
|
|
|||
| if (block.number < uint64(dealTerm.end) - epochs || block.number > uint64(dealTerm.end)) { | |||
| if ( | |||
ravish1729
reviewed
Oct 12, 2023
contracts/mocks/DealStatusMock.sol
Outdated
| @@ -74,7 +74,8 @@ contract DealStatusMock is IAggregatorOracle, ProofMock { | |||
| for (uint256 i = 0; i < activeDealIds.length; i++) { | |||
| uint64 dealID = activeDealIds[i].dealId; | |||
| // get the deal's expiration epoch | |||
| MarketTypes.GetDealActivationReturn memory dealActivationStatus = MarketAPI.getDealActivation(dealID); | |||
| MarketTypes.GetDealActivationReturn memory dealActivationStatus = MarketAPI | |||
ravish1729
reviewed
Oct 12, 2023
contracts/mocks/DealStatusMock.sol
Outdated
| @@ -85,7 +86,10 @@ contract DealStatusMock is IAggregatorOracle, ProofMock { | |||
| } | |||
|
|
|||
| // getExpiringDeals should return all the deals' dealIds if they are expiring within `epochs` | |||
| function getExpiringDeals(bytes memory _cid, uint64 epochs) external view returns (Deal[] memory) { | |||
| function getExpiringDeals( | |||
| bytes memory _cid, | |||
ravish1729
reviewed
Oct 12, 2023
tests/DealStatus.js
Outdated
| expect(activeDeals.toString()).to.be.equal("1234,4321,2222,4321"); | ||
| }); | ||
| await expect(this.dealstatus.complete(1, 2222, 4321, incProof, verifData)) | ||
| .to.emit(this.dealstatus, "CompleteAggregatorRequest") |
ravish1729
reviewed
Oct 12, 2023
tests/DealStatus.js
Outdated
| const allDeals = await this.dealstatus.getAllDeals("0x0181e2039220203f46bc645b07a3ea2c04f066f939ddf7e269dd77671f9e1e61a3a3797e665127"); | ||
| it("Should return all the deals' dealIds if they are expiring within a certain input epoch", async function () { | ||
| const expiringDeals = await this.dealstatus.callStatic.getExpiringDeals( | ||
| "0x0181e2039220203f46bc645b07a3ea2c04f066f939ddf7e269dd77671f9e1e61a3a3797e665127", |
parva-jain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.