Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submitRaaS param changes #6

Merged
merged 1 commit into from
Oct 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions contracts/DealStatus.sol
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,11 @@ contract DealStatus is IAggregatorOracle, Proof {
return transactionId;
}

function submit_raas(
function submitRaaS(
bytes memory _cid,
uint replication_num_copies,
uint repair_threshold,
uint renewal_threshold,
string[] memory miner
uint256 _replication_target,
uint256 _repair_threshold,
uint256 _renew_threshold
) external returns (uint256) {
// Increment the transaction ID
transactionId++;
Expand All @@ -43,7 +42,7 @@ contract DealStatus is IAggregatorOracle, Proof {
txIdToCid[transactionId] = _cid;

// Emit the event
emit SubmitAggregatorRequestRaaS(transactionId, _cid, replication_num_copies, repair_threshold, renewal_threshold, miner);
emit SubmitAggregatorRequestWithRaaS(transactionId, _cid, _replication_target, _repair_threshold, _renew_threshold);
return transactionId;
}

Expand Down
21 changes: 12 additions & 9 deletions contracts/interfaces/IAggregatorOracle.sol
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,25 @@ interface IAggregatorOracle {
// Emitted when a new request is submitted with an ID and content identifier (CID).
event SubmitAggregatorRequest(uint256 indexed id, bytes cid);

// Emitted when a new request is submitted with an ID, content identifier (CID) and other deal parameters.
event SubmitAggregatorRequestRaaS(
uint256 indexed id,
bytes cid,
uint replication_num_copies,
uint repair_threshold,
uint renewal_threshold,
string[] miner
);
// Emitted when a new request is submitted with an ID, content identifier (CID), and RaaS parameters
event SubmitAggregatorRequestWithRaaS(uint256 indexed id, bytes cid,
uint256 _replication_target, uint256 _repair_threshold,
uint256 _renew_threshold);

// Emitted when a request is completed, providing the request ID and deal ID.
event CompleteAggregatorRequest(uint256 indexed id, uint64 indexed dealId);

// Function that submits a new request to the oracle
function submit(bytes memory _cid) external returns (uint256);

// Function to submit a new file to the aggregator, specifing the raas parameters
function submitRaaS(
bytes memory _cid,
uint256 _replication_target,
uint256 _repair_threshold,
uint256 _renew_threshold
) external returns (uint256);

// Callback function that is called by the aggregator
function complete(
uint256 _id,
Expand Down
11 changes: 5 additions & 6 deletions contracts/mocks/DealStatusMock.sol
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,11 @@ contract DealStatusMock is IAggregatorOracle, ProofMock {
return transactionId;
}

function submit_raas(
function submitRaaS(
bytes memory _cid,
uint replication_num_copies,
uint repair_threshold,
uint renewal_threshold,
string[] memory miner
uint256 _replication_target,
uint256 _repair_threshold,
uint256 _renew_threshold
) external returns (uint256) {
// Increment the transaction ID
transactionId++;
Expand All @@ -46,7 +45,7 @@ contract DealStatusMock is IAggregatorOracle, ProofMock {
txIdToCid[transactionId] = _cid;

// Emit the event
emit SubmitAggregatorRequestRaaS(transactionId, _cid, replication_num_copies, repair_threshold, renewal_threshold, miner);
emit SubmitAggregatorRequestWithRaaS(transactionId, _cid, _replication_target, _repair_threshold, _renew_threshold);
return transactionId;
}

Expand Down
21 changes: 12 additions & 9 deletions contracts/mocks/IAggregatorOracleMock.sol
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,24 @@ interface IAggregatorOracle {
// Event emitted when a new request is submitted
event SubmitAggregatorRequest(uint256 indexed id, bytes cid);

// Emitted when a new request is submitted with an ID, content identifier (CID) and other deal parameters.
event SubmitAggregatorRequestRaaS(
uint256 indexed id,
bytes cid,
uint replication_num_copies,
uint repair_threshold,
uint renewal_threshold,
string[] miner
);
// Emitted when a new request is submitted with an ID, content identifier (CID), and RaaS parameters
event SubmitAggregatorRequestWithRaaS(uint256 indexed id, bytes cid,
uint256 _replication_target, uint256 _repair_threshold,
uint256 _renew_threshold);

event CompleteAggregatorRequest(uint256 indexed id, uint64 indexed dealId);

// Function that submits a new request to the oracle
function submit(bytes memory _cid) external returns (uint256);

// Function to submit a new file to the aggregator, specifing the raas parameters
function submitRaaS(
bytes memory _cid,
uint256 _replication_target,
uint256 _repair_threshold,
uint256 _renew_threshold
) external returns (uint256);

// Callback function that is called by the aggregator
function complete(
uint256 _id,
Expand Down
8 changes: 4 additions & 4 deletions tests/DealStatus.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,10 @@ describe("Aggregator Tests", function () {
this.dealstatus.submit(cid)
})

it("Should submit a valid request with other deal parameters", async function () {
await expect(this.dealstatus.submit_raas(cid, 2, 100, 200, ['miner1', 'miner2', 'miner3']))
.to.emit(this.dealstatus, "SubmitAggregatorRequestRaaS")
.withArgs(3, cid, 2, 100, 200, ['miner1', 'miner2', 'miner3'])
it("Should submit a valid request with submitRaaS ", async function () {
await expect(this.dealstatus.submitRaaS(cid, 2, 100, 200))
.to.emit(this.dealstatus, "SubmitAggregatorRequestWithRaaS")
.withArgs(3, cid, 2, 100, 200)
})
})
})