Clean-up: follow-up on removing spec features #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to lightning#1092 that fixes the following issues: - fix a few typos - remove non-zero-fee anchors test cases - remove `remote_pubkey` rotation
ProofOfKeags
approved these changes
May 21, 2024
vincenzopalazzo
approved these changes
May 27, 2024
There was a problem hiding this comment.
ACK 3e9b572
Thanks, and sorry if we missed some of the follow-up comments.
23 tasks
Roasbeef
approved these changes
Jun 3, 2024
| @@ -637,7 +636,7 @@ also subtract two times the fixed anchor size of 330 sats from the funder | |||
|
|
|||
| ## Key Derivation | |||
|
|
|||
| Each commitment transaction uses a unique `localpubkey`, and a `remotepubkey`. | |||
| Each commitment transaction uses a unique `localpubkey`. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1092 that fixes the following issues:
remote_pubkeyrotation