Moved msg type description from BOLT#2 to BOLT#1 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
reviewed
Dec 6, 2016
| @@ -23,6 +23,13 @@ A node MUST NOT send an evenly-typed message not listed here without prior negot | |||
| A node MUST ignore a received message of unknown type, if that type is odd. | |||
| A node MUST fail the channels if it receives a message of unknown type, if that type is even. | |||
|
|
|||
| The messages are grouped logically into 4 groups by their most significant set bit: | |||
|
|
|||
| - Setup & signalling (types `0`-`31`): comprises setup of the cryptographic transport, communication of supported features and error reporting. These are described below. | |||
There was a problem hiding this comment.
You can remove "setup of the cryptographic transport," as that doesn't use these codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes more sense I think, since some messages are described in BOLT #1.