Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOLT 2: upgrade protocol on reestablish #868

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

BOLT 2: upgrade protocol on reestablish #868

wants to merge 3 commits into from

Commits on Aug 30, 2023

  1. BOLT 2: upgrade protocol on reestablish. 

    This is the simplest upgrade mechanism I could come up with.  It's
ready for option_anchors_zero_fee_htlc_tx, too.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>


Header from folded patch 'spell-out-upgrades.patch':

upgrade: spell out upgrade possibilities.

This uses explicit "channel types", which are now merged into master.

Also spell out the potential issues with back-to-back upgrades, and
workarounds if you were to even have this issue.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>


Header from folded patch 'remove-channel-subtype.patch':

BOLT 2: remove channel_type subtype, only allow one upgrade.

We also define channel type elsewhere, so we can remove the
now-outdated one.  And clarify the example.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    836ee95 View commit details
    Browse the repository at this point in the history

  2. features: add explicit option_upgradable. 

    This makes it clear who supports it.  Also point out that it can be
used to enable anchors, and remove link to quiescence protocol, since
this is no longer dependent.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    900be99 View commit details
    Browse the repository at this point in the history

  3. BOLT 1: define what offered and negotiated mean. 

    i.e. it was present in the init feature bits.  We use this in several places, but assume everyone knows what it means.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    084402f View commit details
    Browse the repository at this point in the history