Cut 0.0.115 #2211
Cut 0.0.115 #2211
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2211 +/- ##
==========================================
- Coverage 91.57% 91.54% -0.03%
==========================================
Files 104 104
Lines 51745 51745
Branches 51745 51745
==========================================
- Hits 47386 47371 -15
- Misses 4359 4374 +15 see 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
TheBlueMatt
force-pushed
the
2023-04-0.0.115-cut
branch
2 times, most recently
from
4f971d5
to
ccaafa0
Compare
|
|
||
| ## Security | ||
| * Transaction re-broadcasting is now substantially more aggressive, including a | ||
| new regular rebroadcast feature called on a timer from the |
There was a problem hiding this comment.
"If the rebroadcast is called directly from ChainMonitor::rebroadcast_pending_claims, it can be invoked as a aggressive as every 30s on mobile” ?
Should we say it comes at the downside of inflating the feerate paid? Might be concerning if you’re not using Core’s fee estimator but relying on a mempool only fee estimator.
There was a problem hiding this comment.
It doesnt inflate the feerate, we don't bump on rebroadcasts.
| `ChannelMonitor` on 0.0.114 or before may panic (#2059). Note that this is | ||
| in general unsupported, and included here only for completeness. | ||
|
|
||
| ## Bug Fixes |
There was a problem hiding this comment.
I think 2161 is an API change, but included both, thanks.
TheBlueMatt
force-pushed
the
2023-04-0.0.115-cut
branch
from
ccaafa0
to
035c79c
Compare
|
Want to land #2220 first. |
|
Let's do #2004 as well. |
TheBlueMatt
force-pushed
the
2023-04-0.0.115-cut
branch
from
1c624a2
to
33a396b
Compare
|
Rebased on #2004, updated release notes to include everything, added diff totals. Should be good to go! |
TheBlueMatt
force-pushed
the
2023-04-0.0.115-cut
branch
from
33a396b
to
dafa095
Compare
|
Rebased again, and added the one missing commit. |
Still need to come up with a release name, but here's draft release notes.