Remove panics for sign_holder_commitment_and_htlcs when a signature i… #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmalonson
force-pushed
the
rebroad
branch
2 times, most recently
from
10e0170
to
1d65ab8
Compare
TheBlueMatt
reviewed
Oct 11, 2023
| /// provided later when the signer is online. | ||
| NotAvailable, | ||
| /// The signer failed permanently and we should attempt to close the | ||
| /// channel. |
There was a problem hiding this comment.
Not quite sure I understand the value of this. If we can't sign, we also can't close the channel, and in fact the current handling just panics. We could certainly have this here (like we do for I/O) just as a shortcut for the user to panic, but we should think hard about the value of that first.
If we do keep this error, it should move out of the first commit into a new first commit separately.
|
@TheBlueMatt FYI I'm taking over this PR. |
|
Closing this for #2703 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s not immediately available.