Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async signing test util follow ups #3151

Conversation

alecchendev
Copy link
Contributor

Some followups on #3115.

  • Remove unused unavailable signers in TestKeysInterface
  • Remove unnecessary display implementation for SignerOp
  • Move set of test disabled signer ops to EnforcementState
  • Add method to enable/disable all signer ops at once

- Remove unused unavailable signers in TestKeysInterface
- Remove unnecessary display implementation for SignerOp
- Move set of test disabled signer ops to EnforcementState
- Add method to enable/disable all signer ops at once
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 17.07317% with 34 lines in your changes missing coverage. Please review.

Project coverage is 89.74%. Comparing base (3ccf064) to head (1ce5bbd).
Report is 2 commits behind head on main.

Files Patch % Lines
lightning/src/util/test_channel_signer.rs 17.24% 20 Missing and 4 partials ⚠️
lightning/src/ln/functional_test_utils.rs 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3151      +/-   ##
==========================================
- Coverage   89.81%   89.74%   -0.07%     
==========================================
  Files         121      121              
  Lines       99314    99331      +17     
  Branches    99314    99331      +17     
==========================================
- Hits        89195    89141      -54     
- Misses       7514     7532      +18     
- Partials     2605     2658      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, its only test code so not bothering to wait for another review.

@TheBlueMatt TheBlueMatt merged commit 40283e7 into lightningdevkit:main Jul 8, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants