Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max path length when paying BOLT 12 invoices. #3156

Conversation

valentinewallace
Copy link
Contributor

This should've been done as part of #3026 but got overlooked.

@valentinewallace valentinewallace changed the title 2024 07 b12 max path len Set max path length when paying BOLT 12 invoices. Jul 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 96.87500% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.80%. Comparing base (669a459) to head (678aac0).
Report is 3 commits behind head on main.

Files Patch % Lines
lightning/src/ln/outbound_payment.rs 75.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3156      +/-   ##
==========================================
- Coverage   89.84%   89.80%   -0.05%     
==========================================
  Files         121      121              
  Lines       99454    99526      +72     
  Branches    99454    99526      +72     
==========================================
+ Hits        89357    89381      +24     
- Misses       7498     7533      +35     
- Partials     2599     2612      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question

lightning/src/ln/outbound_payment.rs Show resolved Hide resolved
@valentinewallace
Copy link
Contributor Author

Squashed in nit with this diff:

diff --git a/lightning/src/ln/outbound_payment.rs b/lightning/src/ln/outbound_payment.rs
index a9fba2c56..443a7b2c3 100644
--- a/lightning/src/ln/outbound_payment.rs
+++ b/lightning/src/ln/outbound_payment.rs
@@ -510,7 +510,7 @@ pub enum Bolt12PaymentError {
        UnexpectedInvoice,
        /// Payment for an invoice with the corresponding [`PaymentId`] was already initiated.
        DuplicateInvoice,
-       /// The [`BlindedPath`]s provided are too large and caused us to exceed the maximum onion packet
+       /// The [`BlindedPath`]s provided are too large and caused us to exceed the maximum onion hop data
        /// size of 1300 bytes.
        ///
        /// [`BlindedPath`]: crate::blinded_path::BlindedPath

@valentinewallace
Copy link
Contributor Author

Trivial fix with a test so I'm gonna land with 1 ACK

@valentinewallace valentinewallace merged commit bfc20f8 into lightningdevkit:main Jul 8, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants