Skip incremental-mutants job for main #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no diff when running against main, so we skip incremental-mutants. Before this commit, we'd get `Error: Failed to parse diff: Line 1: Error while parsing:` as the diff file was empty.
tnull
reviewed
Jul 5, 2024
| @@ -250,6 +250,7 @@ jobs: | |||
|
|
|||
| incremental-mutants: | |||
| runs-on: ubuntu-latest | |||
| if: github.ref_name != 'main' # `main` has no diff with itself | |||
There was a problem hiding this comment.
Makes sense, but would the 'real' solution be to check whether the diff is empty and always early-exit if so?
There was a problem hiding this comment.
Yeah it makes the expression a bit more complex and I had considered it. Or it requires an extra step before. I'll see how it can fit in this expression.
There was a problem hiding this comment.
Yeah, don't bother if it's too much hassle I think, just wondered if we might into run similar cases where it wouldn't be main == main.
tnull
approved these changes
Jul 8, 2024
No worries. I was about to say we can look at an expression later. But for now I don't think it will cause issues with other refs even if people open PRs from other remote "main"s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no diff when running against main, so we skip incremental-mutants. Before this commit, we'd get
Error: Failed to parse diff: Line 1: Error while parsing:as the diff file was empty.