multi: migrate forwarding_history table #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the forwarding_history table's schema to relax restrictions: 1. Allow nil outgoing peer: when we can't look up our outgoing peer, we currently do not persist the forward. We only hit this in some edge cases, so we update the schema to allow null values so that we can still persist the forward. 2. Allow non-unique outgoing channel/index: when we fail htlcs locally, the outgoing index will always be 0 in our resolution, so we need to restrict this constraint to be able to record local failures. SQLite has limited alter table functionality available, so this is achieved by creating a temporary table and migrating new values to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83, and while we're here updates
forwarding_historyto allownullougoing_peerto allow still storing forwards in the case where we're not able to lookup peer pubkey (can happen in a few edge cases).