followups: Configurable Forwarding Limit and Stub Improvements #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostjager
reviewed
Oct 6, 2023
joostjager
reviewed
Oct 6, 2023
carlaKC
force-pushed
the
forwarding-history-followups
branch
3 times, most recently
from
5373c1b
to
87b5c05
Compare
|
Rebased this on #82 because the fix is required for tests in this PR + addressed comments. |
joostjager
reviewed
Oct 17, 2023
carlaKC
force-pushed
the
forwarding-history-followups
branch
from
87b5c05
to
0f4a2d3
Compare
joostjager
reviewed
Oct 19, 2023
Previously if there was an error in process/peercontroller, the stub would continue to run and block on sending new htlcs into channels that have nothing listening on the other end. This change passes in the context used by process so that the stub can shut down cleanly.
carlaKC
force-pushed
the
forwarding-history-followups
branch
from
0f4a2d3
to
fa9ee24
Compare
|
Rebased on #82 and addressed final comments! |
joostjager
approved these changes
Oct 20, 2023
| require.Len(t, fwds, 1) | ||
|
|
||
| // Modify the db to have a zero limit on forwarding history. We don't recreate | ||
| // the test db because it would re-create the file. Run limitHTLCRecords once |
There was a problem hiding this comment.
Maybe not the most beautiful way to cover, but good enough I think.
There was a problem hiding this comment.
Yeah :| didn't think it was worth updating the test db setup for this one case, but I agree.. ugly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the follow ups mentioned for #79. Happy to split these up into multiple PRs, but though one would be okay since the changes are fairly minimal.
Depends on #82.