multi: add tower config defaults #7771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
towerConfigDefaults
branch
from
0925c6e
to
b1ada8c
Compare
In this commit, a `DefaultWtClientCfg` function is added which populates some default values for the `WtClient` struct. This is then used to populate the wtclient defaults in the main LND config struct.
ellemouton
force-pushed
the
towerConfigDefaults
branch
2 times, most recently
from
8195b0f
to
d3d7657
Compare
In this commit, a `DefaultWatchtowerCfg` function is added which is used to construct a default `lncfg.Watchtower` struct. This is then used to populate the default watchtower config in the main LND config struct.
This commit removes the `PrivateTowerURIs` member from the `WtClient` config struct. This field has been deprecated since v0.8.0-beta and currently, LND would fail to start if the field was specified.
ellemouton
force-pushed
the
towerConfigDefaults
branch
from
d3d7657
to
7484910
Compare
7 tasks
|
Concept Ack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
DefaultWtclientCfgandDefaultWatchtowerConfigfunctions that populatedefaults for the
lncfg.Wtclientandlncfg.Watchtowerconfig structs. These arethen used in the main LND config struct so that the defaults are shown to a user in
the
lnd --helpcommand.This PR also removes the deprecated
PrivateTowerURIsmember from theWtclientconfig struct since it has been deprecated since
v0.8.0-betaand currently LND wouldfail to start if a user specified it.
Fixes #7769