-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: implement new querying interface #191
Merged
JabobKrauskopf
merged 1 commit into
epic/165-query-engine-refactor-1
from
170-define-query-engine-interface
Sep 4, 2024
Merged
refactor: implement new querying interface #191
JabobKrauskopf
merged 1 commit into
epic/165-query-engine-refactor-1
from
170-define-query-engine-interface
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JabobKrauskopf
force-pushed
the
170-define-query-engine-interface
branch
2 times, most recently
from
September 3, 2024 10:29
3468cfe
to
d2d31d9
Compare
JabobKrauskopf
requested review from
OFranke,
FloLimebit,
philippgrosser and
MarIniOnz
September 3, 2024 10:34
JabobKrauskopf
force-pushed
the
170-define-query-engine-interface
branch
from
September 3, 2024 11:21
d2d31d9
to
8c2d0d5
Compare
Usage examples: def query(node: NodeOperand):
edges_to_treatment = node.outgoing_edges()
edges_to_treatment.target_node().in_group("treatment")
edges_to_outcome = node.outgoing_edges()
edges_to_outcome.target_node().in_group("outcome")
max_time_edge = edges_to_treatment.attribute("time").max()
max_time_edge.less_than(edges_to_outcome.attribute("time"))
medrecord.select_nodes(query) |
JabobKrauskopf
force-pushed
the
170-define-query-engine-interface
branch
2 times, most recently
from
September 3, 2024 11:34
fe7a3a9
to
31971ef
Compare
LauraBoenchenLB
requested changes
Sep 3, 2024
JabobKrauskopf
force-pushed
the
170-define-query-engine-interface
branch
from
September 3, 2024 15:07
31971ef
to
d61f9ac
Compare
LauraBoenchenLB
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool new query engine! Can't wait to use it to build complex queries with 😎
JabobKrauskopf
merged commit Sep 4, 2024
cd391ec
into
epic/165-query-engine-refactor-1
2 of 6 checks passed
JabobKrauskopf
added a commit
that referenced
this pull request
Oct 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old query engine and implements the new query engine as an interface in the
querying.pyi
. All current query engine usage was refactored to use the new interface.It does not include the interface for control flow
Expected tests to fail:
medmodels/medrecord/tests/test_builder.py
medmodels/medrecord/tests/test_datatype.py
medmodels/medrecord/tests/test_indexers.py
medmodels/medrecord/tests/test_medrecord.py
medmodels/medrecord/tests/test_overview.py
medmodels/medrecord/tests/test_schema.py
medmodels/treatment_effect/matching/tests/test_classic_distance_models.py
medmodels/treatment_effect/matching/tests/test_metrics.py
medmodels/treatment_effect/matching/tests/test_propensity_score.py
medmodels/treatment_effect/tests/test_continuous_estimators.py
medmodels/treatment_effect/tests/test_temporal_analysis.py
medmodels/treatment_effect/tests/test_treatment_effect.py