Updating default parsing in AvscParser

[li-ukumar]

What

try to get default values from field definitions after schemas in the same file are resolved.

Why

For a complex schema, with cyclic references, it is possible for field type to be unresolved even though it is fully defined inside the file. So, before checking if we can parse default, wait for all schemas in the file to be resolved.

Test

Added Unit test.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9487a8b) 46.12% compared to head (7a73bdd) 46.13%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #546      +/-   ##
============================================
+ Coverage     46.12%   46.13%   +0.01%     
  Complexity     4539     4539              
============================================
  Files           407      407              
  Lines         28423    28432       +9     
  Branches       4637     4639       +2     
============================================
+ Hits          13109    13117       +8     
+ Misses        13746    13745       -1     
- Partials       1568     1570       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xiaoyu-yang-gh]

Can you add unit tests?

[xiaoyu-yang-gh]

line 197 and 198 are same. duplicate check.

[xiaoyu-yang-gh]

I think we can refactor these code to remove these two continue to make the logic more clear.

The logic is like:
for (AvroSchemaField field : fields) {
SchemaOrRef fieldSchema = field.getSchemaOrRef();
boolean hasDefault = field.hasDefaultValue();
boolean wasDefinedBefore = fieldSchema.isFullyDefined();
if (!wasDefinedBefore) {
if (hasDefault) {
fieldsWithUnparsedDefaults.add(field);
}
} else {
if (!hasDefault) {
if (field.getDefaultValue() instanceof AvscUnparsedLiteral) {
AvscParseUtil.lateParseFieldDefault(field, this);
}
}
}
}

Or you can move the the check if (hasDefault) ahead:

for (AvroSchemaField field : fields) {
if (!field.hasDefaultValue()) {
continue;
}

SchemaOrRef fieldSchema = field.getSchemaOrRef();
boolean wasDefinedBefore = fieldSchema.isFullyDefined();
if (!wasDefinedBefore) {
fieldsWithUnparsedDefaults.add(field);
} else if (field.getDefaultValue() instanceof AvscUnparsedLiteral) {
AvscParseUtil.lateParseFieldDefault(field, this);
}
}