fixed incomplete url #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the catch |
sanketplus
reviewed
Dec 9, 2020
| @@ -1,7 +1,7 @@ | |||
| # Relational Databases | |||
|
|
|||
| ### Prerequisites | |||
| * Complete [Linux course](/linux_basics/intro/) | |||
| * Complete [Linux course](https://linkedin.github.io/school-of-sre/linux_basics/intro/) | |||
There was a problem hiding this comment.
we should be using relative links for internal documents. re: https://www.mkdocs.org/user-guide/writing-your-docs/#linking-to-pages
current one will need to change if we shifted to other domain. mkdocs supports linking internal docs via relative paths
There was a problem hiding this comment.
can you open an issue @sanketplus ?
We can audit and standardise to relative URLs
There was a problem hiding this comment.
ironically this was the only link in the entire document using relative url. literally every other link was an absolute url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebuilt and tested locally.